Skip to content

[WIP] Make package installation in CI fast with uv #19556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

[WIP] Make package installation in CI fast with uv #19556

wants to merge 12 commits into from

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Mar 1, 2024 •
edited by github-actions bot
Loading

What does this PR do?

WIP. Just trying it out.
https://astral.sh/blog/uv

📚 Documentation preview 📚: https://pytorch-lightning--19556.org.readthedocs.build/en/19556/

cc @Borda @carmocca

@github-actions github-actions bot added docs Documentation related ci Continuous Integration labels Mar 1, 2024
@awaelchli awaelchli force-pushed the ci/uv branch 2 times, most recently from 83ff24a to 3f1c76b Compare March 1, 2024 14:13
@awaelchli awaelchli marked this pull request as ready for review March 2, 2024 01:19
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2024 •
edited
Loading

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🔴 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.13, oldest) failure ❌
pl-cpu (macOS-11, lightning, 3.10, 1.13) failure ❌
pl-cpu (macOS-11, lightning, 3.10, 2.1) failure ❌
pl-cpu (macOS-11, lightning, 3.10, 2.2) failure ❌
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13, oldest) failure ❌
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) failure ❌
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) failure ❌
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2) failure ❌
pl-cpu (windows-2022, lightning, 3.8, 1.13, oldest) failure ❌
pl-cpu (windows-2022, lightning, 3.10, 1.13) failure ❌
pl-cpu (windows-2022, lightning, 3.10, 2.1) failure ❌
pl-cpu (windows-2022, lightning, 3.10, 2.2) failure ❌
pl-cpu (macOS-11, pytorch, 3.8, 1.13) failure ❌
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) failure ❌
pl-cpu (windows-2022, pytorch, 3.8, 1.13) failure ❌
pl-cpu (macOS-12, pytorch, 3.11, 2.0) failure ❌
pl-cpu (macOS-12, pytorch, 3.11, 2.1) failure ❌
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0) failure ❌
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1) failure ❌
pl-cpu (windows-2022, pytorch, 3.11, 2.0) failure ❌
pl-cpu (windows-2022, pytorch, 3.11, 2.1) failure ❌

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml.

🔴 fabric: Docs
Check ID Status
docs-make (fabric, doctest) failure ❌
docs-make (fabric, html) failure ❌

These checks are required after the changes to .github/workflows/docs-build.yml.

🔴 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) failure ❌
docs-make (pytorch, html) failure ❌

These checks are required after the changes to .github/workflows/docs-build.yml, requirements/pytorch/docs.txt.

🔴 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.13, oldest) success ✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
fabric-cpu (macOS-11, lightning, 3.11, 2.1) success ✅
fabric-cpu (macOS-11, lightning, 3.11, 2.2) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success ✅
fabric-cpu (windows-2022, lightning, 3.8, 1.13, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.1) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2) success ✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success ✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success ✅
fabric-cpu (macOS-12, fabric, 3.11, 2.0) success ✅
fabric-cpu (macOS-12, fabric, 3.11, 2.1) failure ❌
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0) success ✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.11, 2.0) success ✅
fabric-cpu (windows-2022, fabric, 3.11, 2.1) success ✅

These checks are required after the changes to .github/workflows/ci-tests-fabric.yml.

🔴 lightning_app: Docs
Check ID Status
docs-make (app, doctest) failure ❌
docs-make (app, html) failure ❌

These checks are required after the changes to .github/workflows/docs-build.yml.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@github-actions github-actions bot added pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Mar 2, 2024
@Borda
Copy link
Collaborator

Borda commented Mar 2, 2024

Have you tried locally if it is really faster once you have packages cashed?

@carmocca
Copy link
Contributor

carmocca commented Mar 2, 2024

I also tried (and failed) here Lightning-AI/litgpt#952

@awaelchli awaelchli closed this Apr 1, 2024
@Borda Borda deleted the ci/uv branch July 26, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees

No one assigned

Labels

ci Continuous Integration dependencies Pull requests that update a dependency file docs Documentation related pl Generic label for PyTorch Lightning package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@awaelchli @Borda @carmocca